Remove shelljs.config.fatal #1592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding platform, CLI tries to copy some files from runtime to the native project. When some of the files do not exist and `shelljs.config.fatal` is true, shelljs exits the process without warn. Remove the option for the moment and consider better usage for it.
|
"CLI tries to copy some files from runtime to the native project. When some of the files do not exist" - how so they do not exist? What are these files? |
Contributor
Author
|
@vchimev we have list of files which are expected to exist in current runtime, but when you execute |
|
👍 |
Contributor
Author
|
close and retarget to release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding platform, CLI tries to copy some files from runtime to the native project.
When some of the files do not exist and
shelljs.config.fatalis true, shelljs exits the process without warn.Remove the option for the moment and consider better usage for it.