Pass current stdio to npm install process #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever CLI spawns `npm install <smth>`, we do not set stdin and stdout of the spawned process. This way in case any of the npm scripts executed during install requires input from user, it cannot be handled in any way. So pass the current stdin and stdout to the spawned npm process. This way in case a postinstall script is executed and it requires input from user, the users will be able to enter required information in the same place where `tns` command has been executed (same terminal). This fixes postinstall execution of `nativescript-plugin-firebase`.
rosen-vladimirov
force-pushed
the
vladimirov/fix-plugins-installation
branch
from
a3b9bbc to
8517b71
Compare
Plamen5kov
approved these changes
Feb 12, 2017
Contributor
|
THANKS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever CLI spawns
npm install <smth>, we do not set stdin and stdoutof the spawned process. This way in case any of the npm scripts executed
during install requires input from user, it cannot be handled in any
way.
So pass the current stdin and stdout to the spawned npm process. This
way in case a postinstall script is executed and it requires input from
user, the users will be able to enter required information in the same
place where
tnscommand has been executed (same terminal).This fixes postinstall execution of
nativescript-plugin-firebase. Fixes #2521