Skip to content

Add official support for Node.js 8 #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosen-vladimirov merged 2 commits into from
Jul 14, 2017
Merged

Add official support for Node.js 8 #2979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a1a1a
Add official support for Node.js 8
rosen-vladimirov Jul 14, 2017
f0c9c83
Ensure symlinks from plugins are copied from realpath to platforms dir
rosen-vladimirov Jul 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions lib/tools/node-modules/node-modules-dest-copy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,9 @@ export class TnsModulesCopy {

shelljs.mkdir("-p", targetPackageDir);

let isScoped = dependency.name.indexOf("@") === 0;

if (isScoped) {
// copy module into tns_modules/@scope/module instead of tns_modules/module
shelljs.cp("-Rf", dependency.directory, path.join(this.outputRoot, dependency.name.substring(0, dependency.name.indexOf("/"))));
} else {
shelljs.cp("-Rf", dependency.directory, this.outputRoot);
}
const isScoped = dependency.name.indexOf("@") === 0;
const destinationPath = isScoped ? path.join(this.outputRoot, dependency.name.substring(0, dependency.name.indexOf("/"))) : this.outputRoot;
shelljs.cp("-RfL", dependency.directory, destinationPath);

// remove platform-specific files (processed separately by plugin services)
shelljs.rm("-rf", path.join(targetPackageDir, "platforms"));
Expand Down
Loading