fix: socket not cleared on time for second sync #3783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
force-pushed
the
kddimitrov/fix-two-fast-consecutive-syncs
branch
from
5c41250 to
ccfa6d2
Compare
Fatme
reviewed
Aug 1, 2018
| if (this.socketConnection && this.socketConnection.uid === socketId) { | ||
| this.end(); | ||
| this.socketError = error; | ||
| this.end(error); |
Contributor
There was a problem hiding this comment.
Why do we need to pass error here as parameter? We can use it directly in end() function
public end() {
const error = this.socketError || this.getErrorWithMessage()
}
Contributor
Author
There was a problem hiding this comment.
It is a personal preference. If someone moves this.socketError = error one line down or the error is not cleared at the right moment, the method might be broken without us noticing.
Contributor
Author
|
run ci |
1 similar comment
Contributor
Author
|
run ci |
Fatme
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].