chore: rename exposed methods and events for emulators #3788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
approved these changes
Aug 2, 2018
rosen-vladimirov
force-pushed
the
vladimirov/fix-public-api
branch
from
6575c78 to
9ec4ad9
Compare
Rename `getAvailableEmulators` to `getEmulatorImages` as we return information for all emulator images - running and not. Rename the events `emulatorImagesFound` and `emulatorImagesLost` to `emulatorImageFound` and `emulatorImageLost` as emitted data contains a single emulator image. Add docs for deviceEmitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
getAvailableEmulatorstogetEmulatorImagesas we return information for all emulator images - running and not.Rename the events
emulatorImagesFoundandemulatorImagesLosttoemulatorImageFoundandemulatorImageLostas emitted data contains a single emulator image.Add docs for deviceEmitter
PR Checklist