Skip to content

fix: remove keys from package.json after project is created #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosen-vladimirov merged 1 commit into from
Aug 3, 2018
Merged

fix: remove keys from package.json after project is created #3791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export class LiveSyncTrackActionNames {
}

export const PackageJsonKeysToKeep: Array<String> = ["name", "main", "android", "version", "pluginsData"];
export const TemplatesV2PackageJsonKeysToRemove: Array<String> = ["name", "version", "displayName", "templateType", "author", "keywords", "homepage", "bugs"];

export class SaveOptions {
static PRODUCTION = "save";
Expand Down
4 changes: 2 additions & 2 deletions lib/services/project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as path from "path";
import * as shelljs from "shelljs";
import { format } from "util";
import { exported } from "../common/decorators";
import { Hooks } from "../constants";
import { Hooks, TemplatesV2PackageJsonKeysToRemove } from "../constants";

export class ProjectService implements IProjectService {

Expand Down Expand Up @@ -212,7 +212,7 @@ export class ProjectService implements IProjectService {
const packageJsonData = this.$fs.readJson(projectFilePath);

// Remove the metadata keys from the package.json
let updatedPackageJsonData = _.omitBy<any, any>(packageJsonData, (value: any, key: string) => _.startsWith(key, "_"));
let updatedPackageJsonData = _.omitBy<any, any>(packageJsonData, (value: any, key: string) => _.startsWith(key, "_") || TemplatesV2PackageJsonKeysToRemove.indexOf(key) !== -1);
updatedPackageJsonData = _.merge(updatedPackageJsonData, this.packageJsonDefaultData);

if (updatedPackageJsonData.nativescript && updatedPackageJsonData.nativescript.templateVersion) {
Expand Down