fix: run ios fails if tns-ios version contains tags #3804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
changed the title
rosen-vladimirov
approved these changes
Aug 7, 2018
KristianDD
force-pushed
the
kddimitrov/fix-cloud-run-ios-tag-version
branch
from
ce13908 to
d2d1ddb
Compare
DimitarTachev
approved these changes
Aug 7, 2018
Contributor
DimitarTachev
left a comment
DimitarTachev
left a comment
There was a problem hiding this comment.
we could also add some unit tests for regression testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
tns run ioscommand will fail with:Unable to apply changes on device: xxxxxx. Error is: Invalid Version: rc.What is the new behavior?
The application will be build and deployed
Fixes/Implements/Closes #3803.