fix: don't await for AppLaunching notification when CLI retries to attach to debugger #4047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
reviewed
Oct 22, 2018
| // In case app is already running, we'll fail here as we'll not receive it. | ||
| const appLaunchingNotification = this.$iOSNotification.getAppLaunching(projectId); | ||
| const appLaunchingSocket = await this.$iOSNotificationService.postNotification(deviceIdentifier, appLaunchingNotification, constants.IOS_OBSERVE_NOTIFICATION_COMMAND_TYPE); | ||
| await this.$iOSNotificationService.awaitNotification(deviceIdentifier, +appLaunchingSocket, timeout); |
Contributor
There was a problem hiding this comment.
+appLaunchingSocket looks a bit strange, because this.$iOSNotificationService.postNotification should return a number according to the interface.
Contributor
Author
There was a problem hiding this comment.
I totally agree, but I just moved this code and prefer not changing it.
KristianDD
approved these changes
Oct 22, 2018
Fatme
force-pushed
the
fatme/fix-ios-debug
branch
from
855eb87 to
bea46f8
Compare
…attach to debugger
Fatme
force-pushed
the
fatme/fix-ios-debug
branch
from
bea46f8 to
7aa67a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppLaunching notification is sent only once by runtime during application start. {N} CLI has a logic to retry to attach to debugger if the first attempt is not successful. If the retry logic is executed e.g. application is already running, {N} CLI should not await for AppLaunching request as it'll never receive it.
PR Checklist
What is the current behavior?
tns debug iosdoes not work with bigger projects (master-detail-ng) on slower devices.What is the new behavior?
tns debug iosworks with bigger projects (master-detail-ng) on slower devices.Refs: #4046