chore: skip tns_modules cleanup from CLI #4363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
approved these changes
Feb 13, 2019
In case `--bundle` is passed CLI tries to clean the `tns_modules` directory produced from previous prepare operations. However, this is not required in latest versions as webpack cleans the directory on its own. The current clean was required for Webpack before 0.14.0, particularly the one used with 3.x versions of NativeScript. Delete unit test that is no longer relevant, as it tests functionality that is now handled by `nativescript-dev-webpack` plugin.
rosen-vladimirov
force-pushed
the
vladimirov/do-not-clean-tns_modules
branch
from
e2b21ff to
20874b4
Compare
Contributor
Author
|
run ci |
1 similar comment
Contributor
Author
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
--bundleis passed CLI tries to clean thetns_modulesdirectory produced from previous prepare operations. However, this is not required in latest versions as webpack cleans the directory on its own.The current clean was required for Webpack before 0.14.0, particularly the one used with 3.x versions of NativeScript.
PR Checklist
What is the current behavior?
CLI tries to clean
tns_modulesdir whentns prepare <platform> --bundleis executed.What is the new behavior?
Logic for cleaning
tns_modulesdir is executed innativescript-dev-webpackplugin.