fix: process correctly podfiles without platform's version #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: 1. `tns create myPodApp --js` 2. `tns plugin add nativescript-imagepicker` 3. `tns plugin add nativescript-facebook` 4. Open `node_modules/nativescript-facebook/platforms/ios/Podfile` and replace the file's content with `platform :ios` 5. Open `node_modules/nativescript-imagepicker/platforms/ios/Podfile` and replace the file's content with `platform :ios, '9.0'`
Fatme
added
bug
no-changelog
ghost
added
the
Fatme
changed the title
rosen-vladimirov
approved these changes
Feb 24, 2019
Contributor
Author
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
tns create myPodApp --jstns plugin add nativescript-imagepickertns plugin add nativescript-facebooknode_modules/nativescript-facebook/platforms/ios/Podfileand replace the file's content withplatform :iosnode_modules/nativescript-imagepicker/platforms/ios/Podfileand replace the file's content withplatform :ios, '9.0'PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].
Rel to: #3604