fix: errors are shown on postinstall when using sudo #4493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `sudo npm i -g nativescript` is used, postinstall tasks produce errors, which confuse the users. CLI is actually installed successfully, but error for EACCESS is often shown. The problem is that npm executes the postinstall scripts with a special OS user - `nobody`. This user does not have permissions to write in users' directories, so generating html help or writing the user-settings.json file fails. Npm's solution is to pass `--unsafe-perm` to the `sudo npm install -g nativescript` command, which forces the postinstall to be executed with root user. Fix CLI's code to skip postinstall tasks in case sudo is used and `--unsafe-perm` is not passed.
ghost
assigned
DimitarTachev
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
sudo npm i -g nativescriptis used, postinstall tasks produce errors, which confuse the users. CLI is actually installed successfully, but error for EACCESS is often shown.The problem is that npm executes the postinstall scripts with a special OS user -
nobody. This user does not have permissions to write in users' directories, so generating html help or writing the user-settings.json file fails.Npm's solution is to pass
--unsafe-permto thesudo npm install -g nativescriptcommand, which forces the postinstall to be executed with root user.Fix CLI's code to skip postinstall tasks in case sudo is used and
--unsafe-permis not passed.PR Checklist
What is the current behavior?
sudo npm install -g nativescriptfails with EACCESS, but CLI is installed correctly.What is the new behavior?
sudo npm install -g nativescriptexecutes successfully.Fixes issue #4370