Skip to content

Conversation

@Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 16, 2019

NativeScript CLI doesn't respect correctly hmr: false when the option is provided through dashed options from command. This led to the exception when the application is built using CLI and deployed on device using Xcode as the hmr is included in app's bundle.

Fixes:
#4846
#4814

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

NativeScript CLI doesn't respect correctly `hmr: false` when the option is provided through dashed options from command. This led to the exception when the application is built using CLI and deployed on device using Xcode as the `hmr` is included in app's bundle.

Fixes:
#4846
#4814
@cla-bot cla-bot bot added the cla: yes label Jul 16, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Jul 16, 2019

test cli-smoke cli-devices package_version#rc

@Fatme Fatme added this to the 6.0.1 milestone Jul 16, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Jul 17, 2019

test cli-smoke cli-devices

1 similar comment
@Fatme
Copy link
Contributor Author

Fatme commented Jul 17, 2019

test cli-smoke cli-devices

@Fatme
Copy link
Contributor Author

Fatme commented Jul 17, 2019

test cli-device package_version#rc

@Fatme Fatme merged commit a32e8f1 into release Jul 17, 2019
@Fatme Fatme deleted the fatme/fix-argv branch July 17, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants