Skip to content

Conversation

@rosen-vladimirov
Copy link
Contributor

logger.out has been removed before 6.0 release, but it has still been used in CLI's code. Remove its usages and add tests for errors.beginCommand (the one where the method has been used until now.

PR Checklist

What is the current behavior?

ANDROID_HOME=/invalid tns doctor - fails and in interactive terminal prompts you to select option. If you choose Manually configure, CLI will print error this.$injector.resolve(...).out is not a function (NOTE: In non-interactive terminal the same happens).

What is the new behavior?

ANDROID_HOME=/invalid tns doctor - fails and in interactive terminal prompts you to select option. If you choose Manually configure, CLI will prints where are the system requirements.

Fixes issue #4958

`logger.out` has been removed before 6.0 release, but it has still been used in CLI's code. Remove its usages and add tests for `errors.beginCommand` (the one where the method has been used until now.
@rosen-vladimirov rosen-vladimirov added this to the 6.1.0 milestone Aug 19, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Aug 19, 2019
@cla-bot cla-bot bot added the cla: yes label Aug 19, 2019
@rosen-vladimirov
Copy link
Contributor Author

test cli-smoke cli-misc

@rosen-vladimirov rosen-vladimirov merged commit be3128a into master Aug 19, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-doctor-err branch August 19, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants