This repository was archived by the owner on Feb 9, 2022. It is now read-only.
feat: Validate Java version based on passed runtime version #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow verification of the environment based on a specified Android runtime version. This is required for cases where the package.json of the project is not updated yet, but we need to verify that we can use this runtime
This was referenced May 28, 2018
typings/interfaces.ts
Outdated
| /** | ||
| * Checks if a local build can be executed on the current machine. | ||
| * @param {string} platform The platform for which to check if local build is possible. | ||
| * @param {string} runtimeVersion @optional The runtime version against which the validation is executed. In case this parameter is passed, it takes predescences over the projectDir argument. |
There was a problem hiding this comment.
There seems to be no projectDir argument here?
typings/interfaces.ts
Outdated
| * @param {string} installedJavaVersion The version of javac to check. | ||
| * @param {string} projectDir @optional The project directory. Used to determine the Android Runtime version and validate the Java compiler version against it. | ||
| * If it is not passed or the project does not have Android runtime, this validation is skipped. | ||
| * @param {string} runtimeVersion @optional The runtime version against which the validation is executed. In case this parameter is passed, it takes predescences over the projectDir argument. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow verification of the environment based on a specified Android runtime version. This is required for cases where the package.json of the project is not updated yet, but we need to verify that we can use this runtime