Skip to content

[eslint-plugin] auto fix peer-deps-in-dev-deps#103

Merged
yongholeeme merged 3 commits intomainfrom
feature/97_fixable
Mar 31, 2025
Merged

[eslint-plugin] auto fix peer-deps-in-dev-deps#103
yongholeeme merged 3 commits intomainfrom
feature/97_fixable

Conversation

@yongholeeme
Copy link
Contributor

@yongholeeme yongholeeme commented Mar 17, 2025

Related Issue

close #97

Describe your changes

add-devdeps.mov
empty-devdeps.mov
no-devdeps.mov
indentation.mov

@yongholeeme yongholeeme self-assigned this Mar 17, 2025
@npayfebot
Copy link
Contributor

npayfebot commented Mar 17, 2025

✅ Changeset detected

Latest commit: 2023190

@naverpay/eslint-plugin package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

powered by: naverpay changeset detect-add actions

@yongholeeme yongholeeme changed the title auto fix peer-deps-in-dev-deps [eslint-plugin] auto fix peer-deps-in-dev-deps Mar 17, 2025
@yongholeeme yongholeeme marked this pull request as ready for review March 20, 2025 23:49
@yongholeeme yongholeeme requested a review from a team as a code owner March 20, 2025 23:49
2-one-week
2-one-week previously approved these changes Mar 31, 2025
Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

Comment on lines +57 to +58
const s = ' '.repeat(getIndentationLength(sourceCode.getText()))
const ss = s.repeat(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋ 스페이스 군요 ㅋㅋ

yceffort-naver
yceffort-naver previously approved these changes Mar 31, 2025
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

byhhh2
byhhh2 previously approved these changes Mar 31, 2025
Copy link
Contributor

@byhhh2 byhhh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㄷㄷ
LGTM! 수고많으셨습니다~!

Base automatically changed from feature/97_peerDepsInDevDeps to main March 31, 2025 08:30
@yongholeeme yongholeeme dismissed stale reviews from byhhh2, yceffort-naver, and 2-one-week March 31, 2025 08:30

The base branch was changed.

@yongholeeme yongholeeme merged commit 485cfa9 into main Mar 31, 2025
5 checks passed
@yongholeeme yongholeeme deleted the feature/97_fixable branch March 31, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

peerDepsInDevDeps 개선

5 participants