Merged
Conversation
Nefariusek
requested changes
Jan 2, 2022
Owner
Nefariusek
left a comment
Nefariusek
left a comment
There was a problem hiding this comment.
The whole bubble should fade-in. We want to avoid situations when there is an empty crimson container in the middle of the screen. Please adjust
Comment on lines
+90
to
+96
| imageObject.addEventListener( | ||
| 'load', | ||
| () => { | ||
| renderAnimalFact(imageFact); | ||
| }, | ||
| false, | ||
| ); |
Owner
There was a problem hiding this comment.
There are 2 event listeners for this one object. Additionally, they are in two separate functions so it is hard to maintain. Move everything to the one handler.
Nefariusek
approved these changes
Jan 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bubble with fade-in shows a picture and a fact from both API's at the same time.