Skip to content

Add pre-commit#32

Open
O-J1 wants to merge 4 commits intoNerogar:masterfrom
O-J1:master
Open

Add pre-commit#32
O-J1 wants to merge 4 commits intoNerogar:masterfrom
O-J1:master

Conversation

@O-J1
Copy link
Copy Markdown
Contributor

@O-J1 O-J1 commented Sep 23, 2025

Adds the relevant editorconfig/ruff/pre-commit files that the main repo has. We have confirmed it works on my forked repo on a test branch

Befor merging @dxqb you need to:

  1. Test this commit works locally for you (it did for me but I dont work with mgds)
  2. visit https://pre-commit.ci/
  3. Click on the Sign in With Github
  4. Check if you have the permission to add Nerogar/mgds, you should see a manage if you do. As you can see I dont.
  5. image
  6. If you do then add it, before finally merging this commit

@dxqb
Copy link
Copy Markdown
Collaborator

dxqb commented Nov 18, 2025

I don't have access to this either. Can @Nerogar do this please?

@dxqb
Copy link
Copy Markdown
Collaborator

dxqb commented Feb 3, 2026

access granted by @Nerogar, thanks.
PR ready for merge in itself, but it already finds many ruff errors that should be fixed first.
https://results.pre-commit.ci/run/github/609569864/1770128999.I6XMQC26T1WjoiKN-bT8Iw

@O-J1
Copy link
Copy Markdown
Contributor Author

O-J1 commented Feb 4, 2026

access granted by @Nerogar, thanks. PR ready for merge in itself, but it already finds many ruff errors that should be fixed first. https://results.pre-commit.ci/run/github/609569864/1770128999.I6XMQC26T1WjoiKN-bT8Iw

Honestly, better than I expected when you said many, I got scared it was going to be a huge huge wall of linting erros

@dxqb
Copy link
Copy Markdown
Collaborator

dxqb commented Feb 4, 2026

access granted by @Nerogar, thanks. PR ready for merge in itself, but it already finds many ruff errors that should be fixed first. https://results.pre-commit.ci/run/github/609569864/1770128999.I6XMQC26T1WjoiKN-bT8Iw

Honestly, better than I expected when you said many, I got scared it was going to be a huge huge wall of linting erros

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants