Code tab for other models

[mrerrormessage]

We need to 'hijack' the include function to allow opening, writing, and saving several models at the same time. Probably with a ls:include <file-path-name> or something like that. It's going to be a bit awkward, so if we can find another way of doing this, that would be neat.

[arthurhjorth]

This feels like one of the big ones. I don't know how much time @qiemem spent on looking into it already but maybe @mrerrormessage can take this one? up to you of course, but if you haven't looked into it yet..?

[mrerrormessage]

Is this needed for IDC? This seems like a potentially huge project, so if it's needed it should be started right away.

[arthurhjorth]

If this is at all possible, then YES! :)

This would be a massive improvement to LS modeling in general, and it wold
be amazing to have this ready for initial release at IDC

On Mon, May 11, 2015, 8:31 AM Robert Grider notifications@github.com
wrote:

Is this needed for IDC? This seems like a potentially huge project, so if
it's needed it should be started right away.

—
Reply to this email directly or view it on GitHub
#43 (comment).

[arthurhjorth]

Was thinking about this issue this morning when @cbradyatinquire and I talked about LevelSpace.

I was wondering if there is any way to force the changes to a model into already-opened models, like we do when we recompile models that already have an existing state. Does this question/request make sense?

[mrerrormessage]

I think the question makes sense. I don't know enough about LevelSpace and loading to know for sure whether that's possible, and how much effort it would be if it is possible. Why don't you create a separate issue and mention this one in there. Once this one is complete, we can revisit that issue and give a full answer on it.

[arthurhjorth]

Good call - will do!

[mrerrormessage]

I think we can keep this one open, as saving to the included models seems like a step in the process.

[qiemem]

Didn't mean to close it. Sorry about that!

[mrerrormessage]

Will be adding menu items under "Tabs"

New LevelSpace Model... // prompt user to choose a filename
Open LevelSpace Model |> // list of open levelspace models
Open Model As LevelSpace  // dialog to choose model

Each adds a tab with the filename, just like an include nls would.

[arthurhjorth]

When we merge this we need to take out TPL reporting. But don't do it in this branch - LevelSpaceXWGUI depends on it.

[qiemem]

It doesn't look like this is used anywhere. Left over from debugging?

[qiemem]

I think you can make this an object instead, right? There's no need to instantiate a new one for every invocation.

[mrerrormessage]

Comments addressed. Thanks for reviewing!

[mrerrormessage]

These changes look good, I just had one comment. We're still opening and closing headless models as needed, which is inefficient in the case of reloading (I was incorrect in thinking that the code didn't actually swap models out earlier).

[qiemem]

I was incorrect in thinking that the code didn't actually swap models out earlier

Are you sure about that? I see a way for headless models to be swapped in, but no way for them to be swapped out again.

Anyway, I didn't make the change as I was uncomfortable with making such an extensive architectural change the day before demo.

[SethTisue]

I am not aware of the existence of any support in HeadlessWorkspace for loading a new model.