Skip to content

Read connectionsPerEndpoint when connecting #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jking-stripe wants to merge 1 commit into
base: releases/3.x
Choose a base branch
from
Open

Read connectionsPerEndpoint when connecting #818

jking-stripe wants to merge 1 commit into from

Conversation

@jking-stripe
Copy link

@jking-stripe jking-stripe commented Jan 9, 2026

Context

Original PR: #815

  • Content is the same, but merging into releases/3.x

Adjusts how and when the connectionsPerEndpoint property gets read. Rather than reading the property early, this change delays reading it until attempting to connect to previous stages. This will allow for configuration on a per-job basis.

This also includes some additional adjustments to remove minConnectionsToSubscribe as a parameter of the WorkerPublisherRemoteObservable constructors, neither of which use it. This allows for the removal of a numWorkersAtStage helper.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@jking-stripe jking-stripe marked this pull request as ready for review January 12, 2026 19:09
@jking-stripe
Copy link
Author

jking-stripe commented Jan 12, 2026

cc @kmg-stripe

@jking-stripe jking-stripe requested a deployment to Integrate Pull Request January 22, 2026 01:34 — with GitHub Actions Waiting
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Test Results

662 tests   652 ✅  8m 50s ⏱️
152 suites   10 💤
152 files      0 ❌

Results for commit 8ceef37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmg-stripe kmg-stripe kmg-stripe approved these changes

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@Andyz26 Andyz26 Awaiting requested review from Andyz26 Andyz26 is a code owner

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

@hellolittlej hellolittlej Awaiting requested review from hellolittlej hellolittlej is a code owner

@dtrager02 dtrager02 Awaiting requested review from dtrager02 dtrager02 is a code owner

@james-lubin james-lubin Awaiting requested review from james-lubin james-lubin is a code owner

+1 more reviewer

@agalindo-stripe agalindo-stripe agalindo-stripe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jking-stripe @agalindo-stripe @kmg-stripe