Add support for MGA S-ADM Virtual Tracks (SMPTE ST 2067-203)#376
Merged
fschleich merged 40 commits intoNetflix:masterfrom Sep 10, 2024
Merged
Add support for MGA S-ADM Virtual Tracks (SMPTE ST 2067-203)#376fschleich merged 40 commits intoNetflix:masterfrom
fschleich merged 40 commits intoNetflix:masterfrom
Conversation
Feature/adm audio sequence
Additional 2067-204 tests
Adds 2067-203 and 2067-204 checks to master branch
fschleich
requested review from
danielhdz13-netflix,
davidt-netflix and
fschleich
fschleich
reviewed
Aug 22, 2024
fschleich
reviewed
Aug 22, 2024
- deleted duplicate UL constant MGAAudioEssenceUncompressedSoundCoding - deleted unused UL constant IMF_MGASADM_ESSENCE_CLIP_WRAPPED_ELEMENT_UL - aligned naming of remaining constants with SMPTE metadata register
fschleich
reviewed
Aug 23, 2024
| Constructor<?> constructor = clazz.getConstructor(IMFCompositionPlaylistType.class, Set.class); | ||
| composition = (ApplicationComposition) constructor.newInstance(imfCompositionPlaylistType, homogeneitySelectionSet); | ||
| imfErrorLogger.addAllErrors(composition.getErrors()); | ||
| // ST 2067-203 MGASADMVirtualTrackParameterSet checks |
Contributor
There was a problem hiding this comment.
Could there be a better place to invoke this IMFMGASADMConstraintsChecker.checkMGASADMVirtualTrackParameterSet() method? Maybe in the inheritors of the ApplicationComposition class?
Since this is a factory class that doesn't invoke any other constraints checks, there may be a better, more targeted place to perform these validations.
Contributor
Author
There was a problem hiding this comment.
| @@ -0,0 +1,452 @@ | |||
| /* | |||
| * | |||
| * Copyright 2024 RheinMain University of Applied Sciences, Wiesbaden, Germany. | |||
Contributor
There was a problem hiding this comment.
Can this be removed?
- reverting updates to previously deprecated method - maintaining (but deprecated) existing constructor without support for extension properties
fschleich
reviewed
Aug 28, 2024
fschleich
reviewed
Aug 28, 2024
fschleich
reviewed
Aug 28, 2024
fschleich
reviewed
Aug 28, 2024
fschleich
reviewed
Aug 28, 2024
fschleich
reviewed
Aug 28, 2024
fschleich
reviewed
Aug 29, 2024
fschleich
reviewed
Aug 29, 2024
fschleich
reviewed
Aug 29, 2024
fschleich
reviewed
Aug 29, 2024
…traintsChecker.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
…taSubDescriptor.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
…traintsChecker.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
…traintsChecker.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
…leConstraints.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
…leConstraints.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
fschleich
reviewed
Aug 31, 2024
…leConstraints.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
…leConstraints.java Co-authored-by: Florian Schleich <floschleich@gmail.com>
fschleich
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions and test cases for 2067-203 virtual tracks.