This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Find and register watchers and auditors #182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks promising. It's taking some time to review because it's a larger change. I want to make sure @DenverJ knows this PR is appreciated. |
|
Any plans to incorporate these changes any time soon? Also, is there any accompanying documentation for how to implement new watchers/auditors using this pluggable framework? (BTW - 👍 for these changes!) |
|
This would be a huge improvement. I would very much like to see this incorporated into the master branch. It would streamline development and make it easier for people to contribute. So... bump 💯 :) |
|
Is there any timeline for merging this? I have been working on something similar but would very much prefer to pull down from master. |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the points in #157 - namely watchers and auditors as pluggable modules which allows people to drop in their own modules and have multiple auditors related to one watcher/technology. It all reduces the amount of boilerplate code required to set up a new 'monitor'.
This finds all watchers and auditors under the relevant paths and ignores any modules in the respective 'custom' folders.
The watchers and auditors use meta-classes to register themselves as valid watchers/auditors.