This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Fix item 'first_seen' query #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type: generic-bugfix Why is this change necessary? The 'First Seen' datetime on the Items page was showing as the Last Modified time. Netflix bug report Netflix#377 This change addresses the need by: The view tried to reorder the item.revisions relationship to ascending, which did not work because it was decending in the relationship declaration. Added a seperate ascending query to get the first seen Potential Side Effects: Adds additional DB queries to the items list page, but the impact should be very small because of pagination. The dashboard used a different path.
Contributor
|
This doesn't seem to have corrected the problem for me. |
Contributor
|
oh nevermind - I'm looking at a branch that doesn't have this commit merged in. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: generic-bugfix
Why is this change necessary?
The 'First Seen' datetime on the Items page was showing as the Last Modified
time.
Netflix bug report #377
This change addresses the need by:
The view tried to reorder the item.revisions relationship to ascending, which
did not work because it was decending in the relationship declaration. Added
a seperate ascending query to get the first seen
Potential Side Effects:
Adds additional DB queries to the items list page, but the impact should be
very small because of pagination. The dashboard used a different path.