This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Add bulk enable/disable account service #457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using notes to give detailed information on problems and fixes in some cases. This will allow for more information before truncating.
Type: feature Why is this change necessary? Prior to this change, you would need to update the source code in order to change the values of audit issue scores. This change addresses the need by: Providing a way for administrators to override audit issue scores as they see fit for their organization. Support is added to both the Security Monkey web console (Settings -> Audit Issue Scores) and the manage.py CLI (add_override_score). Potential Side Effects: No known side effects
Contributor
Author
|
Want to factor out some of the intermediate commits here so they can be incorporated separately. Closing for the moment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Why is this change necessary?
As the number of accounts being watched increases, it becomes harder to manage different environments and which accounts they should be watching. This service enables an API and command-line tool (through manage.py) that allows a bulk list of accounts to be enabled or disabled in one command.
Side effects:
To reduce merge conflicts, this builds upon the earlier PRs from the BW team today (#455 and #456 ). Merge this one after the other two (or ask us to cherry-pick / merge independently if the other ones don't pass muster).