Skip to content
This repository was archived by the owner on Sep 17, 2021. It is now read-only.

Conversation

@acknosyn
Copy link
Contributor

Is this a valid problem? My IDE won't stop complaining about the missing file until I delete the references.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.801% when pulling bc711a8 on badraufran:feature/remove_broken_packages_references into 5f42984 on Netflix:develop.

@scriptsrc
Copy link
Contributor

weird - Are you using pycharm?

@scriptsrc scriptsrc added the bug label Jan 31, 2017
@acknosyn
Copy link
Contributor Author

Yip

@acknosyn
Copy link
Contributor Author

broken_packages_link_pycharm

It's not breaking anything, but I just like to be as clean as possible. If it doesn't need to be there, I think it should be removed.

@scriptsrc
Copy link
Contributor

The packages file hasn't been touched since the initial commit 3 years ago.

http://blog.sethladd.com/2015/08/new-dart-sdk-eliminates-symlinks.html
( ^ we don't currently have a .packages file to replace the symlinks,)

However, looks like Travis was still able to build the project on this PR:

[Info from Dart2JS]:
Took 0:00:37.318234 to compile security_monkey|web/main.dart.
Built 280 files to "build".

I think this is probably safe to merge.

@scriptsrc scriptsrc merged commit d3ecc0c into Netflix:develop Jan 31, 2017
This was referenced Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants