This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Supertom acct type #540
Merged
Supertom acct type #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the Account Type field in three places: 1. The item_component_table (item table on main screen). 2. Item details (appears in sidebar) 3. Search Bar. Autocomplete is also supported. This change is meant as UI only; no logic changes have been made as part of this PR.
… into supertom-acct_type
Contributor
|
@MonkeySecurity Thanks for cleaning up my tabs and print statements! I'll be sure to catch those in the future. |
cstewart87
reviewed
Feb 15, 2017
| 'regions': '', | ||
| 'technologies': '', | ||
| 'accounts': '', | ||
| 'accounttypess': '', |
Contributor
There was a problem hiding this comment.
@cstewart87 it definitely is, thanks for catching!
cstewart87
reviewed
Feb 15, 2017
| 'regions': '', | ||
| 'technologies': '', | ||
| 'accounts': '', | ||
| 'accounttypess': '', |
Contributor
|
@MonkeySecurity, @cstewart87 caught two typos of mine (misspelling of accounttypes). How should we handle? Another PR? |
Contributor
Author
|
Sure! Whatever is easiest. |
This was referenced Apr 14, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #536.
Updating the reports dropdown in ui.html for the new url param.
Other minor updates.
@supertom