This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Add Watcher configuration #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type: generic-large-feature Why is this change necessary? We've run into instances where we have wanted to reconfigure watcher run intervals to improve performance or even remove watchers that were causing problems. Currently this requires logging into the server and physically changing the code This change addresses the need by: Provides a Watcher Config page in Settings and an api where a user can configure the run interval and the active flag Potential Side Effects: No known side effects
…/security_monkey into Bridgewater-9331_AddWatcherConfigs
Contributor
Author
|
Side Effect (?) The default in this PR is a 1440 minute interval for all watchers. This is a change many users may not expect. |
Contributor
Author
|
Changed the default from 1 day to 1 hour. |
This was referenced Feb 21, 2017
This was referenced Apr 14, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes merge conflicts from #533
@kalpatel01 message:
Type: generic-large-feature
Why is this change necessary?
We've run into instances where we have wanted to reconfigure watcher run
intervals to improve performance or even remove watchers that were
causing problems. Currently this requires logging into the server and
physically changing the code
This change addresses the need by:
Provides a Watcher Config page in Settings and an api where a user can
configure the run interval and the active flag
Potential Side Effects:
No known side effects