This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Fix justification preservation bug #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type: general-bugfix Why is this change necessary? Any item configuration change (ephemeral or non-ephemeral) causes Security Monkey to remove existing audit issues, which in turn also removes and justifications on said issues. While audit issues are re-added during the next audit, justifications are lost. Adding test coverage for watcher class when there are changes, no changes, and ephemeral changes. This change addresses the need by: Ensuring audit issues are preserved when config changes are detected for any item. Potential Side Effects: No known side effects
This was referenced Apr 14, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: general-bugfix
Why is this change necessary?
Any item configuration change (ephemeral or non-ephemeral) causes
Security Monkey to remove existing audit issues, which in turn also
removes and justifications on said issues. While audit issues are
re-added during the next audit, justifications are lost.
Adding test coverage for watcher class when
there are changes, no changes, and ephemeral
changes.
This change addresses the need by:
Ensuring audit issues are preserved when config changes are detected for
any item.
Potential Side Effects:
No known side effects