This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Explicitly set export filename #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type: generic-bugfix Why is this change necessary? Some browsers/environments download export file as plaintext, without .csv file extension. This change addresses the need by: Explicitly setting the exported filename to 'security-monkey-items.csv' as part of the response header. Potential Side Effects: No known side effects
This was referenced Apr 14, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: generic-bugfix
Why is this change necessary?
Some browsers/environments download export file as plaintext, without
.csv file extension.
This change addresses the need by:
Explicitly setting the exported filename to 'security-monkey-items.csv'
as part of the response header.
Potential Side Effects:
No known side effects