Skip to content
This repository was archived by the owner on Sep 17, 2021. It is now read-only.

Conversation

@scriptsrc
Copy link
Contributor

PR #576 allowed for automatically setting user roles based on group membership.

This had an unanticipated impact on our install where user roles were being downgraded to View on login. The reason is that the PR modified existing users as well as new users. Also, the PR required a new config value ADMIN_GROUP / JUSTIFY_GROUP be placed into the config file. Also, the PR checked the SSO response for the keyword groups, whereas our SSO returns googleGroups.

  • I've modified the SSO code to check the profile for both groups and for googleGroups when using PING.
  • I also modified the SSO code to only assign a role for new user creation. Existing users will not be impacted. This means the current security_monkey installs won't be required to modify their config file to maintain current functionality.

…uire all users to update their config files.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 56.659% when pulling 22534ed on sso_updates into 6b10971 on develop.

@scriptsrc scriptsrc merged commit 20f6335 into develop Mar 9, 2017
@scriptsrc scriptsrc deleted the sso_updates branch April 5, 2017 23:04
This was referenced Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants