This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Skip listing attachments for unused IAM policies #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS IAM watcher attempts to list attachments for all policies within an account for users, groups, and roles. This causes a minimum of three calls to iam:ListEntitiesForPolicy for every policy even if the attachment count for a policy is zero. This change reduces the number of calls by checking the attachment count of a policy before listing the attached entities. For accounts with a large number of unused policies or additional tools calling IAM, this prevents unnecessary volume and helps prevent throttling by AWS.
Contributor
|
Nice. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS IAM watcher attempts to list attachments for all policies within an account for users, groups, and roles. This causes a minimum of three calls to iam:ListEntitiesForPolicy for every policy even if the attachment count for a policy is zero. This change reduces the number of calls by checking the attachment count of a policy before listing the attached entities. For accounts with a large number of unused policies or additional tools calling IAM, this prevents unnecessary volume and helps prevent throttling by AWS.