Skip to content
This repository was archived by the owner on Sep 17, 2021. It is now read-only.

Conversation

@scriptsrc
Copy link
Contributor

@scriptsrc scriptsrc commented May 5, 2017

Summary:

  • Creates a CloudauxWatcher as an abstract class which subclasses Watcher.
    • Replaces IAM User, S3, and ELB watchers with a new simpler sublcass of CloudauxWatcher.
    • Creates new ALB watcher as subclass.
  • Creates a CloudauxBatchedWatcher as an abstract class which sublclasses CloudauxWatcher.
    • Replaces IAM Role watcher with a new simpler subclass of CloudauxBatchedWatcher.
  • Adds tests for the ELB Auditor.
  • Updates ELB Auditor to work with new boto3 cloudaux ELB watcher.

New watchers for technologies in cloudaux will be much simpler.
Need to build out a few more technologies before merging.

TODO:

  • - Need to handle region specific technologies better (elb, elbv2)

  • - Need to make a batched_watcher subclass for others to inherit.

  • - Watchers probably need a method to identify what regions they can exist in.

  • - Watchers need a method to identify how to extract the name from the datastructure.
    (Could help simplify the ignore_list logic as well as ensuring name= is passed to @record_exception decorated get_method invocations)

  • ELB Auditor needs to be re-written to use the new CloudAux format.

  • May need to update CloudAux to also pull all SSL policies.

Going to push the GCP part to another PR.

  • GCP Watchers need a baseclass similar to CloudAuxWatcher

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 61.573% when pulling 9818895 on cloudaux_watcher into 5cd728c on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 61.739% when pulling 051eac1 on cloudaux_watcher into 5cd728c on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 61.736% when pulling 051eac1 on cloudaux_watcher into 5cd728c on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 61.736% when pulling 74d7514 on cloudaux_watcher into 5cd728c on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 61.736% when pulling b9fd6f4 on cloudaux_watcher into 5cd728c on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 63.041% when pulling 67ee41b on cloudaux_watcher into 4eb4fc9 on develop.

@scriptsrc scriptsrc changed the title [WIP] generic cloudaux watcher subclass New simplified Watcher format for CloudAux technologies. May 12, 2017
@scriptsrc scriptsrc merged commit 1903e60 into develop May 12, 2017
@scriptsrc scriptsrc mentioned this pull request May 24, 2017
@scriptsrc scriptsrc deleted the cloudaux_watcher branch May 25, 2017 05:19
mcpeak pushed a commit that referenced this pull request Sep 4, 2017
New simplified Watcher format for CloudAux technologies.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants