This repository was archived by the owner on Sep 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 784
New simplified Watcher format for CloudAux technologies. #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
051eac1 to
74d7514
Compare
Merged
mcpeak
pushed a commit
that referenced
this pull request
Sep 4, 2017
New simplified Watcher format for CloudAux technologies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
New watchers for technologies in cloudaux will be much simpler.
Need to build out a few more technologies before merging.
TODO:
- Need to handle region specific technologies better (elb, elbv2)
- Need to make a batched_watcher subclass for others to inherit.
- Watchers probably need a method to identify what regions they can exist in.
- Watchers need a method to identify how to extract the name from the datastructure.
(Could help simplify the ignore_list logic as well as ensuring
name=is passed to@record_exceptiondecoratedget_methodinvocations)ELB Auditor needs to be re-written to use the new CloudAux format.
May need to update CloudAux to also pull all SSL policies.
Going to push the GCP part to another PR.