Skip to content
This repository was archived by the owner on Sep 17, 2021. It is now read-only.

Conversation

@supertom
Copy link
Contributor

Prepend project id string to arn field to avoid key collusions.

Fixes #725.

Two possible concerns here:

  • This could make the arn very long. Not a problem for the db column (Text), but could be for places on screen.
  • Anyone using the existing version will end up with different arns after an update. Still, since GCP functionality is young, might make sense to do it now

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.046% when pulling 1d875c1 on supertom:granular-gcp-arn into abb176f on Netflix:develop.

@scriptsrc scriptsrc merged commit 4787f46 into Netflix:develop May 19, 2017
@scriptsrc scriptsrc mentioned this pull request May 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants