Skip to content

add id initializer list test #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copperlight merged 1 commit into from
Dec 8, 2023
Merged

add id initializer list test #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.13)

project(spectator)
project(spectator-cpp)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED True)
Expand Down
3 changes: 1 addition & 2 deletions spectator/id.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ class Tags {
public:
Tags() = default;

Tags(
std::initializer_list<std::pair<absl::string_view, absl::string_view>> vs) {
Tags(std::initializer_list<std::pair<absl::string_view, absl::string_view>> vs) {
for (auto& pair : vs) {
add(pair.first, pair.second);
}
Expand Down
6 changes: 6 additions & 0 deletions spectator/id_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,15 @@ using spectator::Tags;
TEST(Id, Create) {
Id id{"foo", Tags{}};
EXPECT_EQ(id.Name(), "foo");
EXPECT_EQ(id.GetTags().size(), 0);

Id id_tags{"name", Tags{{"k", "v"}, {"k1", "v1"}}};
EXPECT_EQ(id_tags.Name(), "name");
EXPECT_EQ(id_tags.GetTags().size(), 2);

std::shared_ptr<Id> id_of{Id::of("name", Tags{{"k", "v"}, {"k1", "v1"}})};
EXPECT_EQ(id_of->Name(), "name");
EXPECT_EQ(id_of->GetTags().size(), 2);
}

TEST(Id, Tags) {
Expand Down