replace invalid characters in ids#106
Merged
copperlight merged 1 commit intoNetflix:mainfrom Jul 16, 2024
Merged
Conversation
dmuino
reviewed
Jul 15, 2024
dmuino
reviewed
Jul 15, 2024
copperlight
force-pushed
the
replace-invalid-chars
branch
4 times, most recently
from
94eced0 to
290b08a
Compare
dmuino
reviewed
Jul 16, 2024
It is easy enough to break the spectatord line protocol, if any of the control characters (`:,=`) are inserted in unexpected places. Since metric names and tags are often programmatically generated, we want to only construct id strings which are valid.
copperlight
force-pushed
the
replace-invalid-chars
branch
from
290b08a to
3c18502
Compare
fvallenilla
pushed a commit
to fvallenilla/spectator-cpp
that referenced
this pull request
Aug 2, 2024
It is easy enough to break the spectatord line protocol, if any of the control characters (`:,=`) are inserted in unexpected places. Since metric names and tags are often programmatically generated, we want to only construct id strings which are valid.
fvallenilla
pushed a commit
to fvallenilla/spectator-cpp
that referenced
this pull request
Aug 2, 2024
It is easy enough to break the spectatord line protocol, if any of the control characters (`:,=`) are inserted in unexpected places. Since metric names and tags are often programmatically generated, we want to only construct id strings which are valid.
fvallenilla
pushed a commit
to fvallenilla/spectator-cpp
that referenced
this pull request
Aug 2, 2024
It is easy enough to break the spectatord line protocol, if any of the control characters (`:,=`) are inserted in unexpected places. Since metric names and tags are often programmatically generated, we want to only construct id strings which are valid.
fvallenilla
pushed a commit
to fvallenilla/spectator-cpp
that referenced
this pull request
Aug 4, 2024
It is easy enough to break the spectatord line protocol, if any of the control characters (`:,=`) are inserted in unexpected places. Since metric names and tags are often programmatically generated, we want to only construct id strings which are valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is easy enough to break the spectatord line protocol, if any of the control characters (
:,=) are inserted in unexpected places. Since metric names and tags are often programmatically generated, we want to only construct id strings which are valid.