Skip to content

Add A TTL Gauge#113

Merged
copperlight merged 1 commit intoNetflix:mainfrom
ecbadeaux:ttl-gauge
Apr 8, 2025
Merged

Add A TTL Gauge#113
copperlight merged 1 commit intoNetflix:mainfrom
ecbadeaux:ttl-gauge

Conversation

@ecbadeaux
Copy link
Copy Markdown
Contributor

Add a TTL Gauge

Copy link
Copy Markdown
Collaborator

@copperlight copperlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some small changes.

Comment thread spectator/stateless_meters.h Outdated
Comment thread spectator/stateless_meters.h Outdated
Comment thread spectator/gauge_test.cc Outdated
@ecbadeaux ecbadeaux force-pushed the ttl-gauge branch 3 times, most recently from 7b97b8d to c33f660 Compare April 8, 2025 16:16
Copy link
Copy Markdown
Collaborator

@copperlight copperlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, then we are good.

Comment thread spectator/stateless_meters.h Outdated
Copy link
Copy Markdown
Collaborator

@copperlight copperlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@copperlight copperlight marked this pull request as ready for review April 8, 2025 17:23
@copperlight copperlight merged commit 234bf0b into Netflix:main Apr 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants