Skip to content

Conversation

@xclaesse
Copy link

@xclaesse xclaesse commented Dec 4, 2025

It is needed to use libvmaf as Meson subproject, like GStreamer does.

Also fix public header includes:
Applications, and thus our public headers, should be included as
#include <libvmaf/libvmaf.h>. Adding include/libvmaf into include
directories means applications could do e.g. #include <feature.h>
which is ambiguous.

@kylophone
Copy link
Collaborator

Seems like this will break everyone's libvmaf build once merged? Is that right? What are the alternatives?

@xclaesse
Copy link
Author

xclaesse commented Dec 4, 2025

Seems like this will break everyone's libvmaf build once merged? Is that right? What are the alternatives?

Yeah, it breaks scripts that does meson setup libvmaf build instead of just make, unfortunately.

I updated this PR to move stuff around so we can build from both toplevel and libvmaf/ subdir. The top level project() call is duplicated as well as meson_options.txt, it's not too bad.

I added a warning() when building in libvmaf/ subdir, that can serve as transition.

Applications, and thus our public headers, should be included as
`#include <libvmaf/libvmaf.h>`. Adding `include/libvmaf` into include
directories means applications could do e.g. `#include <feature.h>`
which is ambiguous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants