Update --aom_ctc v1.0 to clip infinite dB values. #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylophone
force-pushed
the
libvmaf_aom_ctc_clip_db
branch
from
61ec605 to
d843830
Compare
kylophone
force-pushed
the
libvmaf_aom_ctc_clip_db
branch
from
435e199 to
67bfdc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following feature extractor options:
psnr:min_ssefloat_ssim:clip_dbfloat_ms_ssim:clip_dbAlong with these feature extractor options,
--aom_ctc v1.0has been updated to clip PSNR/SSIM dB values according to the AOM CTC. Rationale for this is to avoid infinite values in the case of lossless comparisons.Also in this PR is a commit to avoid building FFmpeg in our Windows Github Actions build. There is something in the CI environment which has changed which is causing this to fail. Rather than debug this now, I'm just turning it off. We have a separate CI job to build FFmpeg on Ubuntu and that is still active and passing.