Skip to content

rfc: Improve performance and IO #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
john-bv merged 26 commits into from
May 1, 2023
Merged

rfc: Improve performance and IO #13

john-bv merged 26 commits into from
May 1, 2023

Conversation

@john-bv
Copy link
Member

@john-bv john-bv commented Apr 9, 2023

This rewrite aims to improve the API and over-all usage of binary utilities.

This RFC implements BC so projects using BinaryUtil can take full benefit of the newer performance improvements.
 

There is however, one BC break, in the condition that a Streamable trait implements a function that will fetch a position prior to the current position. Meaning if you fetch a position before the current buffer's index, the compose function will break. This break is not considered viable enough to support.

@john-bv john-bv linked an issue Apr 9, 2023 that may be closed by this pull request
feat: Rewrite internals #12
Closed
@john-bv john-bv self-assigned this Apr 9, 2023
@john-bv john-bv linked an issue Apr 26, 2023 that may be closed by this pull request
rfc: Proc Macros #14
Closed
@john-bv john-bv marked this pull request as ready for review April 27, 2023 03:02
@john-bv john-bv mentioned this pull request May 1, 2023
Open
@john-bv john-bv added API This issue is related to the API API Break Breaks the Application Programming Interface Code Review A code review is needed before this issue is merged. In Progress Issue is being worked on. labels May 1, 2023
john-bv
john-bv commented May 1, 2023
View reviewed changes
@john-bv john-bv added Code Review Complete The code review for this issue has been completed; and is now being finalized. and removed Code Review A code review is needed before this issue is merged. labels May 1, 2023
@john-bv john-bv merged commit 58f8fbf into master May 1, 2023
@john-bv john-bv deleted the rewrite branch May 1, 2023 22:07
@john-bv john-bv added Completed This issue has been completed. and removed Code Review Complete The code review for this issue has been completed; and is now being finalized. In Progress Issue is being worked on. labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@john-bv john-bv

Labels

API Break Breaks the Application Programming Interface API This issue is related to the API Completed This issue has been completed.

Projects

Netrex Beta
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rfc: Proc Macros feat: Rewrite internals

2 participants

@john-bv