Clarify boolean error message #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation accepts "yes" or "no" as valid values, but then proceeds to report "NOT yes or no" as an error message in case of a validation failure. This clarifies the error message to better hint at what the valid, and what the invalid values are. Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
|
NetworkManager-openvpn is a GNOME project. It's home is https://gitlab.gnome.org/GNOME/NetworkManager-openvpn Please open a merge request there. The ability to open pull requests on this fork should be disabled, but I think that is not possible with github. Sorry about the confusion. |
Author
|
Ah, thank you @thom311! I was confused about the low number of pull requests, but did not find references to any other repositories. Maybe in addition to the project link, the GitLab link could be added to the repository description as well? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation accepts "yes" or "no" as valid values, but then proceeds to report "NOT yes or no" as an error message in case of a validation failure.
This clarifies the error message to better hint at what the valid, and what the invalid values are.