Skip to content

Fix markdown code block text visibility in light mode #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shantur merged 3 commits into from
Feb 12, 2026
Merged

Fix markdown code block text visibility in light mode #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
612ec6a
Fix markdown code block text visibility in light mode
seanburkes Feb 12, 2026
67a530a
Fix rendering for light mode table and diagnostic sections; add guard…
seanburkes Feb 12, 2026
9ea4f6b
fix: light/dark mode consistency with alternating table row colors
seanburkes Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions packages/ui/src/styles/markdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import "github-markdown-css/github-markdown-dark.css";
@import "github-markdown-css/github-markdown-light.css" layer(github-markdown-base);

@layer components {
.markdown-body {
Expand Down Expand Up @@ -108,17 +108,23 @@
background: transparent;
}

.markdown-body pre {
.markdown-body pre:not(.shiki) {
font-family: var(--font-family-mono);
font-size: var(--font-size-sm);
line-height: var(--line-height-normal);
background-color: var(--surface-code);
color: var(--text-primary);
border: 1px solid var(--border-base);
border-radius: 8px;
padding: 0.75rem;
margin: 1rem 0;
}

.markdown-body pre:not(.shiki) code,
.markdown-code-block pre:not(.shiki) code {
color: var(--text-primary);
}

.markdown-body blockquote {
border-left: 3px solid var(--border-base);
color: var(--text-secondary);
Expand Down Expand Up @@ -151,29 +157,29 @@
width: 100%;
margin: 1rem 0;
background-color: transparent;
display: block;
padding-right: 0.75rem;
}

.markdown-body thead,
.markdown-body tbody,
.markdown-body tfoot {
width: 100%;
display: table;
table-layout: fixed;
}

.markdown-body th,
.markdown-body td {
border: 1px solid var(--border-base);
padding: 0.5rem 0.75rem;
text-align: left;
color: var(--text-primary);
background-color: transparent;
}

.markdown-body th {
background-color: var(--surface-secondary);
}

.markdown-body tbody > tr:nth-child(odd) > td {
background-color: var(--markdown-table-row-odd);
}

.markdown-body tbody > tr:nth-child(even) > td {
background-color: var(--markdown-table-row-even);
}

.markdown-code-block {
position: relative;
margin: 10px 0;
Expand Down
6 changes: 6 additions & 0 deletions packages/ui/src/styles/tokens.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
--surface-muted: #f8fafc;
--surface-code: #f1f5f9;
--surface-hover: #e0e0e0;
--markdown-table-row-odd: transparent;
--markdown-table-row-even: #f1f5f9;

/* Border tokens */
--border-base: #e0e0e0;
Expand Down Expand Up @@ -180,6 +182,8 @@
--surface-muted: #212529;
--surface-code: #1a1a1a;
--surface-hover: #3a3a3a;
--markdown-table-row-odd: #0f1114;
--markdown-table-row-even: #181c22;

/* Border tokens */
--border-base: #3a3a3a;
Expand Down Expand Up @@ -347,6 +351,8 @@
--surface-muted: #212529;
--surface-code: #1a1a1a;
--surface-hover: #3a3a3a;
--markdown-table-row-odd: #0f1114;
--markdown-table-row-even: #181c22;

/* Border tokens */
--border-base: #3a3a3a;
Expand Down