fix(ui): hide keyboard hints on phone layout#168
Conversation
|
In your change Check what was discussed in teh original issue. Rather than deciding in places where keyboard hints are shown |
|
Automation failed. session.prompt failed: fetch failed -- |
|
Try again |
|
Automation failed. session.prompt failed: fetch failed -- |
|
Try again |
|
Updated PR to centralize layout gating inside
Please re-check on widths <1280px (tablet/phone): no keyboard hint UI should render; >=1280px: hints render as before. -- |
|
2 Issues
Please fix it. |
|
Fixed both issues:
Can you re-check:
PR: #168 (branch -- |
What changed
phonelayout.KeyboardHintrow and the selectorKbdhints from mobile layouts while keeping them for tablet/desktop.How “phone mode” is detected
packages/ui/src/components/instance/instance-shell2.tsxcomputeslayoutModeviauseMediaQuerybreakpoints:desktop:(min-width: 1280px)tablet:(min-width: 768px)phoneisPhoneLayout = layoutMode() === "phone"is passed down toSessionSidebar.Implementation details
packages/ui/src/components/instance/shell/SessionSidebar.tsxwraps both shortcut hint blocks in<Show when={!props.isPhoneLayout()}>.Verification
tsc: command not found).--
Yours, CodeNomadBot