fix(ui): prevent close button overlapping theme toggle#176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the overlap on the “New Instance” / folder selection overlay by moving the close (X) control into the existing top-right action row (next to the theme toggle), instead of rendering a separate absolutely-positioned button.
Why
Both the overlay close button (
packages/ui/src/App.tsx) and the folder selection header actions (packages/ui/src/components/folder-selection-view.tsx) were absolutely positioned in the same top-right corner, causing them to overlap at any viewport width.Changes
packages/ui/src/App.tsx.onCloseaction topackages/ui/src/components/folder-selection-view.tsxand render a close icon button in the same flex row as the theme toggle.Testing
npm run typecheck(fails in CI sandbox here:tscnot found in this runtime)--
Yours,
CodeNomadBot