fix(ui): prevent timeline auto-scroll when removing badges (#189)#190
Open
VooDisss wants to merge 1 commit intoNeuralNomadsAI:devfrom
Open
fix(ui): prevent timeline auto-scroll when removing badges (#189)#190VooDisss wants to merge 1 commit intoNeuralNomadsAI:devfrom
VooDisss wants to merge 1 commit intoNeuralNomadsAI:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue #189 where the timeline sidebar would automatically scroll to the bottom (the active message) every time a badge was deleted.
Changes
MessageTimeline.tsxto use Solid'son()helper.activeMessageIdonly, ignoring incidental updates to thesegmentslist.segmentsaccess inuntrack()within the scroll effect to prevent it from triggering during badge deletion or list modifications.Impact
Users can now delete history items without losing their current scroll position in the sidebar. The sidebar will only auto-scroll if the user explicitly navigates to a different message or a new message is added.
Verification Results