-
Notifications
You must be signed in to change notification settings - Fork 226
Offline emissions #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline emissions #956
Conversation
|
Here, instead of a new parameter, can we make some tests (such as initialize and see if it fails, or use some routine from codecarbon) and automatically determine (something like try and catch)? |
|
Online is always better, or no? |
|
My major concern with online mode is that in some private infrastructures, networked table lookups are unreliable. Specifically in my case, I'm using private infra through the University of Washington. I've seen that when online mode fails, CodeCarbon defaults to Kansas in the middle of USA; Kansas has different emissions from Washington. I would say online mode is always preferable, except for the default after failure that I'm seeing in my case. Others with similar setups would also run into the same inaccurate emissions tracking. In my local environment I tried to use offline mode parameters when configuring |
bruAristimunha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small points and it is good for me
Signed-off-by: Bru <a.bruno@aluno.ufabc.edu.br>
… into offline-emissions
… into offline-emissions
|
Suuuper good, many thanks @davisethan |
Signed-off-by: Bru <a.bruno@aluno.ufabc.edu.br>
…zed tests - Fixed bug where codecarbon_offline attribute was not set when codecarbon_config is None - Added self.codecarbon_offline = False for default configuration - Created comprehensive test suite with pytest parametrization - Tests cover all offline parameters, online mode, and attribute existence - Reduced code duplication by using @pytest.mark.parametrize - All 15 test cases pass (12 run, 3 skipped when codecarbon not installed) Fixes issues in: - examples/tutorials/tutorial_3_benchmarking_multiple_pipelines.py - examples/advanced_examples/plot_filterbank_csp_vs_csp.py - examples/advanced_examples/plot_hinss2021_classification.py - examples/advanced_examples/plot_use_an_X_y_dataset.py - examples/advanced_examples/plot_statistical_analysis.py
|
Thanks for being an active maintainer @bruAristimunha |
Described by #955.