Possible change to 'auto/install' - for 'rpmbuild' against sed -i 's#data_dir=.*#data_dir=\$(DESTDIR)

[peterbowey]

May I suggest a patch for those Centos / Redhat / Fedora builders that create RPM packages; and build / add modules via 'rpmbuild -bb file.spec' (using filename.tar.gz additions + add-ons - for Nginx modules):

        test -d '\$(DESTDIR)$NGX_PREFIX/html' \
                || cp -R $NGX_HTML '\$(DESTDIR)$NGX_PREFIX'

        test -d '\$(DESTDIR)$NGX_PREFIX/naxsi' || mkdir -p '\$(DESTDIR)$NGX_PREFIX/naxsi'
        cp -R naxsi/nx_util '\$(DESTDIR)$NGX_PREFIX/naxsi/'
        cp -R naxsi/naxsi_config '\$(DESTDIR)$NGX_PREFIX/naxsi/'
-       sed -i 's#naxsi_core_rules=.*#naxsi_core_rules=\$(DESTDIR)$NGX_PREFIX/naxsi/naxsi_config/naxsi_core.rules#' '\$(DESTDIR)$NGX_PREFIX/naxsi/nx_util/nx_util.conf'
+       sed -i 's#naxsi_core_rules=.*#naxsi_core_rules=$NGX_PREFIX/naxsi/naxsi_config/naxsi_core.rules#' '\$(DESTDIR)$NGX_PREFIX/naxsi/nx_util/nx_util.conf'
-       sed -i 's#data_dir=.*#data_dir=\$(DESTDIR)$NGX_PREFIX/naxsi/nx_util/nx_datas#' '\$(DESTDIR)$NGX_PREFIX/naxsi/nx_util/nx_util.conf'
+       sed -i 's#data_dir=.*#data_dir=$NGX_PREFIX/naxsi/nx_util/nx_datas#' '\$(DESTDIR)$NGX_PREFIX/naxsi/nx_util/nx_util.conf'
END

Otherwise a 'rpmbuild' shows errors against using "$(DESTDIR)" for the 'sed -i 's#data_dir=...'

[InfoHunter]

if you do this, are you sure the naxsi_core_rules and data_dir lines in file nx_util.conf are set correctly? Because if user specify DESTDIR environment variable when making install SEnginx, sed will do the things wrong in nx_util.conf.

By the way, what errors did rpmbuild show? Were they something like "Found 'some-path' in installed files; aborting" ?

[peterbowey]

Paul,

Sorry I was so slow to respond to your above query (at 17 days ago)!

I had to 'justify' to do a new rebuild, and thanks to your recent SEnginx 'updates' - I 'finally' had a logical motivation to do so: (here are the results)

Without the change I suggested (above), you get this RPM build 'error status':

+ /usr/lib/rpm/check-buildroot
/root/rpmbuild/BUILDROOT/nginx-1.5.13-1.fc20.x86_64/usr/share/nginx/naxsi/nx_util/nx_util.conf:data_dir=/root/rpmbuild/BUILDROOT/nginx-1.5.13-1.fc20.x86_64/usr/share/nginx/naxsi/nx_util/nx_datas
/root/rpmbuild/BUILDROOT/nginx-1.5.13-1.fc20.x86_64/usr/share/nginx/naxsi/nx_util/nx_util.conf:naxsi_core_rules=/root/rpmbuild/BUILDROOT/nginx-1.5.13-1.fc20.x86_64/usr/share/nginx/naxsi/naxsi_config/naxsi_core.rules
Found '/root/rpmbuild/BUILDROOT/nginx-1.5.13-1.fc20.x86_64' in installed files; aborting
error: Bad exit status from /var/tmp/rpm-tmp.Zxd92g (%install)

RPM build errors:
    Macro %with_file needs whitespace before body
    Bad exit status from /var/tmp/rpm-tmp.Zxd92g (%install)

With my suggested change (above) - no 'error' issue results (a successful build results).

And thanks for keeping the 'SEnginx' updates so 'timely' aligned to the original nginx Master at http://hg.nginx.org/nginx/shortlog. You are never more than a few days behind....

[peterbowey]

By the way, I have successfully 'patched' in the newer changes at http://hg.nginx.org/nginx/shortlog to the current github SEnginx code.

Additionally, I have added the well known 'ngx_pagespeed' at https://github.com/pagespeed/ngx_pagespeed - with a excellent result in a working concept.

(The above work is based on the 'modpagespeed' project created by Google -> https://code.google.com/p/modpagespeed/ )

[InfoHunter]

Yep, pagespeed is a great module, I planed to add this module into SEnginx but no time to test it.

It's good to know that ngx_pagespeed can work with SEnginx!

[InfoHunter]

Why not using the spec file in SEnginx repository to build the rpm package? The file is at rpm/ directory and can build rpm from source tar ball. With this spec file, you can bypass the 'Found xxxxxx in installed file; aborting' issue.

[peterbowey]

The reason is that I spent a number of years doing my own advanced nginx spec file for Fedora RPM packaging. So I suggest that I am too lazy to re-structure the [new] default one arriving with SEnginx.

[InfoHunter]

This problem is so specific and it doesn't affect main features. Consider this as 'won't fix'. Issue closed.

[dawidmalina]

To work arround this issue with rpmbuild I simply add this line to spec file (below %pre section):
sed -i -e 's|%{buildroot}||g' '%{buildroot}/etc/senginx/naxsi/nx_util/nx_util.conf

After this rpm packeges generate ok

[InfoHunter]

Yep, it's easy to work around this, but the problem it that @peterbowey 's own spec file did not suit naxsi well. So it's not a generic problem.

[dawidmalina]

That's not true. I had the same issue with spec from SEnginx repository (rpm folder). So it's like generic issue:)

[InfoHunter]

What is the detailed problem you met with the original spec file from SEnginx repository?

[dawidmalina]

Building rpmbuild -bb -v rpmbuild/SPECS/senginx.spec end with error:

• /usr/lib/rpm/check-buildroot
  /home/user/rpmbuild/BUILDROOT/senginx-1.6.1-0.el6.x86_64/etc/senginx/naxsi/nx_util/nx_util.conf:data_dir=/home/user/rpmbuild/BUILDROOT/senginx-1.6.1-0.el6.x86_64/etc/senginx/naxsi/nx_util/nx_datas
  /home/user/rpmbuild/BUILDROOT/senginx-1.6.1-0.el6.x86_64/etc/senginx/naxsi/nx_util/nx_util.conf:naxsi_core_rules=/home/user/rpmbuild/BUILDROOT/senginx-1.6.1-0.el6.x86_64/etc/senginx/naxsi/naxsi_config/naxsi_core.rules
  Found '/home/user/rpmbuild/BUILDROOT/senginx-1.6.1-0.el6.x86_64' in installed files; aborting
  błąd: Błędny stan wyjścia z /var/tmp/rpm-tmp.oZabWz (%install)

Błędy budowania pakietu RPM:
Błędny stan wyjścia z /var/tmp/rpm-tmp.oZabWz (%install)