Skip to content

Update to latest angular translate#15

Merged
MichaelMarner merged 1 commit intomasterfrom
feature/ngx-translate
Jun 30, 2017
Merged

Update to latest angular translate#15
MichaelMarner merged 1 commit intomasterfrom
feature/ngx-translate

Conversation

@zbarbuto
Copy link
Member

@zbarbuto zbarbuto commented Jun 20, 2017

Since it imports from that module, projects using the newer @ngx-translate won't compile.

@zbarbuto zbarbuto requested a review from MichaelMarner June 20, 2017 03:38
@zbarbuto
Copy link
Member Author

zbarbuto commented Jun 20, 2017

Having said this, is there any way to use any rather than importing directly from the module so that it's truly optional?

@coveralls
Copy link

coveralls commented Jun 20, 2017

Coverage Status

Coverage remained the same at 73.759% when pulling 0c9137d on feature/ngx-translate into 789898c on master.

@MichaelMarner
Copy link
Contributor

MichaelMarner commented Jun 30, 2017

Thanks, and I'll look into making translate a peer dep.

@MichaelMarner MichaelMarner merged commit d0de38b into master Jun 30, 2017
@MichaelMarner MichaelMarner mentioned this pull request Oct 11, 2017
Merged
@MichaelMarner MichaelMarner deleted the feature/ngx-translate branch May 16, 2018 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelMarner MichaelMarner Awaiting requested review from MichaelMarner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zbarbuto @coveralls @MichaelMarner