Skip to content

2022 Code Refresh#29

Merged
LaikaN57 merged 1 commit intoNextdoor:masterfrom
LaikaN57:2022-refresh
Mar 25, 2022
Merged

2022 Code Refresh#29
LaikaN57 merged 1 commit intoNextdoor:masterfrom
LaikaN57:2022-refresh

Conversation

@LaikaN57
Copy link
Member

@LaikaN57 LaikaN57 commented Mar 24, 2022

  • Removed circle lint/test (I intend to fast-follow to add github actions)
  • Update Makefile to use python3 and venv. We also put in some good boiler-plate
  • Ran isort and black on all code and setup.py
  • Changed to f-strings
  • Updated logging.warn calls to logging.warning calls
  • Ensured logging.log calls used %s strings (not that we need to, just good practice)
  • Moved from nosetest to pytest
  • Fixed literal comparison warning with is not (The original thing that was annoying me and lead to the scope-creep that is this PR.)
  • Version bump 1.0.3 to 1.0.4
  • Updated requirements to be a bit more sane

...The tests pass.

Supersedes #28

I am soft-deprecating Python 2 support although all of this should still work just fine in Python 2 still.

@LaikaN57 LaikaN57 merged commit d5d0776 into Nextdoor:master Mar 25, 2022
@LaikaN57 LaikaN57 deleted the 2022-refresh branch March 25, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants