Skip to content

Fix deferrals card#3

Open
jkaczmarek1 wants to merge 1 commit intoNexxed:mainfrom
jkaczmarek1:patch-1
Open

Fix deferrals card#3
jkaczmarek1 wants to merge 1 commit intoNexxed:mainfrom
jkaczmarek1:patch-1

Conversation

@jkaczmarek1
Copy link
Copy Markdown

No description provided.

@Nexxed
Copy link
Copy Markdown
Owner

Nexxed commented Feb 6, 2023

Can you explain what this is supposed to fix? @jkaczmarek1

@KillStr3aK
Copy link
Copy Markdown

Can you explain what this is supposed to fix? @jkaczmarek1

Well, currently you aren't doing anything with complete just setting it to false, and the deferrals.done set it to true but thats it, nothing else

I'm not saying that this pr contains any fix, never used the resource, but it seems like I've mentioned above

@jkaczmarek1
Copy link
Copy Markdown
Author

@Nexxed my bad I did not provide any description for that.
Basically, when you try to use deferrals, it's automatically going to next deferral due to missing wait (even if the user did not complete a specific deferral). With this fix, script waiting until previous deferral will be completed.

@Dalrae1
Copy link
Copy Markdown

Dalrae1 commented Mar 24, 2023

Good change. Luckily all of my deferrals are in the same thread so this is not an issue for me.

@KillStr3aK
Copy link
Copy Markdown

Lua is single threaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants