fix(docker): install git for GitHub-hosted npm deps#51
Closed
burning-bush-dev wants to merge 1 commit into
Closed
Conversation
The node:22-trixie-slim image lacks git, which npm needs to resolve `github:` dependencies like hapi-swagger. This broke the docker CI job after the hapi-swagger dep was changed to github:KozyOps/hapi-openapi. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merged
Contributor
|
100% on the diagnosis, but I <bows head in shame> have a different solution in the oven. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slim node image doesn't ship git, which npm needs to clone
github:dependencies. Thehapi-swaggerswap togithub:KozyOps/hapi-openapionrelease-3.0.0-alpha.12triggers the failure --npm installtries to spawn git inside the container and getsENOENT.One-liner:
apt-get install gitbeforenpm install. Should unblock thetest-dockerCI job.🤖 Generated with Claude Code