Compress a directory even if you are on a file now #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Shift-Up going to the I guess if it were wrapped in an option that could be disabled I wouldn't mind (so true by default would be fine). Something like |
Author
|
I added such option. What is a usecase for disabling "go to parent from file" functionality? Why someone may want it? |
Collaborator
|
Usecase is since it's making one action do two things based on context. I know I'll personally turn it off since I don't want to go to parent if I accidentally press left twice or something like that. But that's just me. I'll merge soon. |
sum01
added a commit
that referenced
this pull request
Feb 15, 2018
sum01
added a commit
that referenced
this pull request
Feb 15, 2018
Also some minor optimizations, and a line-break on the README. We don't need to save the GetOption call. The compress_target function can also be canceled early to prevent an unnecessary refresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #29